Skip to content

Replace python setup.py test with pytest#185

Merged
sverhoeven merged 11 commits intomainfrom
72-run-tests-with-pytest
Apr 20, 2021
Merged

Replace python setup.py test with pytest#185
sverhoeven merged 11 commits intomainfrom
72-run-tests-with-pytest

Conversation

@sverhoeven
Copy link
Copy Markdown
Member

@sverhoeven sverhoeven commented Apr 20, 2021

Fixes #72
Fixes #142
Fixes #147
Fixes #182

README is for users not developers of the package.
Also rewrote testing chapter to be up to date with current features
As setup.cfg already switches on coverage
@sverhoeven sverhoeven marked this pull request as ready for review April 20, 2021 08:01
@eriktks eriktks self-requested a review April 20, 2021 08:39
Comment thread CONTRIBUTING.md Outdated
Co-authored-by: Erik Tjong Kim Sang <erikt@xs4all.nl>
Copy link
Copy Markdown
Member

@eriktks eriktks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read issues, checked cod changes, ran pytest tests. All was well!

@jspaaks jspaaks self-requested a review April 20, 2021 10:08
@sverhoeven sverhoeven merged commit f386d49 into main Apr 20, 2021
@sverhoeven sverhoeven deleted the 72-run-tests-with-pytest branch April 20, 2021 10:11
@jspaaks
Copy link
Copy Markdown

jspaaks commented Apr 20, 2021

but wait I was still reviewing

Copy link
Copy Markdown

@jspaaks jspaaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple more comments

Comment thread tests/test_project.py
Comment thread tests/test_project.py
Comment thread tests/test_project.py
Comment thread tests/test_project.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run the tests for the generated package use pytest to run tests Use pip install in test 'python setup.py test' is deprecated

3 participants